On Thu, Jan 26, 2012 at 5:43 AM, Vik Reykja <vikrey...@gmail.com> wrote: > On Wed, Jan 25, 2012 at 22:19, Giuseppe Sucameli <brush.ty...@gmail.com> > wrote: >> >> thinking you have no skills, I wrote a patch too and posted it to >> hackers ML about 2 days ago, but I didn't subscribe that list so >> it is stalled, waiting for someone's approval. >> >> For this reason my email is not displayed in the archives. >> I'm so sorry both have wasted our time in writing 2 patches for >> the same bug. > > I think your patch is more complete than mine so it's definitely not > wasted. I spent several hours on mine and now I have a little bit of skills > :-) > > Thank you for your effort; I'm sorry if you feel you have wasted your time.
I think Vik's patch is better, because it doesn't rely as much on things that happen to be true today - like which relkinds have system columns associated with them. But I do agree we ought to handle both the ADD COLUMN and RENAME COLUMN cases, and as such have posted an update of Vik's patch on the other thread. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Compan -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
