On Thu, Aug 4, 2011 at 09:30:35PM +0000, Christoph Anton Mitterer wrote:
>
> The following bug has been logged online:
>
> Bug reference: 6150
> Logged by: Christoph Anton Mitterer
> Email address: cales...@scientia.net
> PostgreSQL version: 0.9
> Operating system: Debian sid
> Description: commit_delay should have unit ms
> Details:
>
> Hi.
>
> AFAIK form the documentation, the setting commit_delay, should have the base
> unit "ms".
>
> However, when doing something like
> $ psql -c 'SELECT name,vartype,unit FROM pg_settings;' | grep commit_delay
> I get:
> could not change directory to "/root/test"
> commit_delay | integer |
>
> No unit.
Yes, you are correct. The attached, applied patch for Postgres 9.3 will
properly display units. I checked all the other variables and they all
had proper units.
I also removed an unnecessary units designation in
postgresql.conf.sample for a zero value --- if we want to put units on
zero values, we should do it consistently in a separate patch.
--
Bruce Momjian <br...@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
new file mode 100644
index 80e5aa1..a1d303b
*** a/src/backend/utils/misc/guc.c
--- b/src/backend/utils/misc/guc.c
*************** static struct config_int ConfigureNamesI
*** 2033,2039 ****
{"commit_delay", PGC_USERSET, WAL_SETTINGS,
gettext_noop("Sets the delay in microseconds between transaction commit and "
"flushing WAL to disk."),
! NULL
},
&CommitDelay,
0, 0, 100000,
--- 2033,2040 ----
{"commit_delay", PGC_USERSET, WAL_SETTINGS,
gettext_noop("Sets the delay in microseconds between transaction commit and "
"flushing WAL to disk."),
! NULL,
! GUC_UNIT_MS
},
&CommitDelay,
0, 0, 100000,
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
new file mode 100644
index c24afb0..adcbcf6
*** a/src/backend/utils/misc/postgresql.conf.sample
--- b/src/backend/utils/misc/postgresql.conf.sample
***************
*** 137,143 ****
# - Cost-Based Vacuum Delay -
! #vacuum_cost_delay = 0ms # 0-100 milliseconds
#vacuum_cost_page_hit = 1 # 0-10000 credits
#vacuum_cost_page_miss = 10 # 0-10000 credits
#vacuum_cost_page_dirty = 20 # 0-10000 credits
--- 137,143 ----
# - Cost-Based Vacuum Delay -
! #vacuum_cost_delay = 0 # 0-100 milliseconds
#vacuum_cost_page_hit = 1 # 0-10000 credits
#vacuum_cost_page_miss = 10 # 0-10000 credits
#vacuum_cost_page_dirty = 20 # 0-10000 credits
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
