On Thu, Aug 16, 2012 at 3:28 PM, Dave Page <dp...@pgadmin.org> wrote: > On Thu, Aug 16, 2012 at 3:26 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Dave Page <dp...@pgadmin.org> writes: >>> So Sachin and I have looked at this but not found a problem with the >>> installers. He then found that one of our colleagues has already >>> reported this as an issue with PostgreSQL and submitted a possible >>> patch. So, we need a committer to look at fixing this: >> >>> http://archives.postgresql.org/pgsql-hackers/2012-06/msg00874.php >> >> Seems pretty brute-force. Why not just >> >> #if LIBXML_VERSION > 20703 >> #define HAVE_XMLSTRUCTUREDERRORCONTEXT >> #endif >> >> in some suitable place (probably xml.c itself, since I don't think we >> want to #include xmlversion.h in global headers)? >> >> Or actually, maybe we could just unconditionally define >> HAVE_XMLSTRUCTUREDERRORCONTEXT in pg_config.h.win32. Is anybody >> likely to still be building PG with ancient libxml on Windows? > > That works for me. Using older libxml's would be a bad idea anyway - > and there are precompiled binaries available, so it's not hard to get.
Works as in, I'm happy with it. I haven't tested. Though, it'll likely break some of the old BF animals (temporarily, I hope). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
