On 2012-12-04 18:05:15 -0800, Jeff Janes wrote:
> On Tue, Dec 4, 2012 at 4:20 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> > Jeff Janes <jeff.ja...@gmail.com> writes:
> >> I've reproduced it again using the just-tagged 9.2.2, and uploaded a
> >> 135MB tarball of the /tmp/data_slave2 and /tmp/archivedir to google
> >> drive. The data directory contains the recovery.conf which is set to
> >> end recovery between the two critical time points.
> >
> > Hmmm ... I can reproduce this with current 9.2 branch tip. However,
> > more or less by accident I first tried it with a 9.2-branch postmaster
> > from a couple weeks ago, and it works as expected with that: the log
> > output looks like
> >
> > LOG: restored log file "00000001000000000000001B" from archive
> > LOG: restored log file "00000001000000000000001C" from archive
> > LOG: restored log file "00000001000000000000001D" from archive
> > LOG: database system is ready to accept read only connections
> > LOG: recovery stopping before commit of transaction 305610, time
> > 2012-12-02 15:08:54.000131-08
> > LOG: recovery has paused
> > HINT: Execute pg_xlog_replay_resume() to continue.
> >
> > and I can connect and do the pg_xlog_replay_resume() thing.
>
> But the key is, the database was not actually consistent at that
> point, and so opening hot standby was a dangerous thing to do.
>
> The bug that allowed the database to open early (the original topic if
> this email chain) was masking this secondary issue.
>
> > So apparently this is something we broke since Nov 18. Don't know what
> > yet --- any thoughts? Also, I am still not seeing what the connection
> > is to the original report against 9.1.6.
>
> The behavior that we both see in 9.2.2, where it waits for a
> pg_xlog_replay_resume() that cannot be delivered because the database
> is not yet open, is the same thing I'm seeing in 9.1.6. I'll see if I
> can repeat it in 9.1.7 and post the tarball of the data directory.
Could you check whether the attached patch fixes the behaviour?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
diff --git a/src/backend/access/transam/xlog.c
b/src/backend/access/transam/xlog.c
index 4118070..bd309fe 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -5786,7 +5786,8 @@ StartupXLOG(void)
* Pause only if users can connect to
send a resume
* message
*/
- if (recoveryPauseAtTarget &&
standbyState == STANDBY_SNAPSHOT_READY)
+ if (recoveryPauseAtTarget &&
reachedConsistency
+ && standbyState ==
STANDBY_SNAPSHOT_READY)
{
SetRecoveryPause(true);
recoveryPausesHere();
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
