-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 01.05.2013 01:53, schrieb Tom Lane: > adrian.vondendrie...@credativ.de writes: >> [ recent pg_dump fails against an 8.4 server if "old" is used as >> a name ] > > Yeah. The reason for this is that "old" was considered a reserved > word in 8.4 and before, but since 9.0 it is not reserved (indeed it > isn't a keyword at all anymore), so 9.0 and later pg_dump don't > think they need to quote it in commands. > > De-reserving a keyword happens sufficiently rarely that it doesn't > really seem worth teaching pg_dump about such cases. There is a > workaround, which is to use the --quote-all-identifiers switch > when dumping from a server with an incompatible idea of the set of > reserved keywords.
I've tested the workaround and it works. But, because the error originaly happens when upgrading from 8.4 to 9.1, I'm interested in a way how I could force pg_upgrade to tell pg_dump to use this switch. IMO: When there is such a switch, it should be on by default when upgrading from 8.4 (or lower) to a version >= 9.1 to prevent this kind of error. Did I miss something that would break in this scenario when - --quote-all-identifiers is used by default while upgrading from <= 9.0? > > For the archives' sake, it might be worth noting that > --quote-all-identifiers was added in 9.1, which means that 9.0 > pg_dump is vulnerable to this problem and has no workaround. > That's a bit annoying, but I rather doubt we'll take the trouble to > back-port --quote-all-identifiers into 9.0 at this point. > > regards, tom lane > Regards - Adrian * Englisch - erkannt * Englisch * Deutsch * Englisch * Deutsch <javascript:void(0);> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRgQN7AAoJEJg+KbLX08eJo+QH/3WUV9qj2WTv1YaBRL2A0BxJ 0xwYUEKKZn++E7wU7hJSstY9vS7uQJEnSicQT1GcEZREYwJkR2vqMZUUKX1aB2KU KnHLmRE3+4OWAIwNYIDOL00BMlAZ+brRkxWy7zERpMDkcsuo7v29rsWiwI0RggDf U+Dt/JZaMfWCEobo9dBFyW1jGOkOs378JMltWV71JUEW2MfAh24KTL35IjlK47Vi ZPYpFWsnLJDJlq33Lx7+GM9PIK/xRefXJZZLkjHaXcNMkTdu05nEsehuARcZt9Vz OW1k2W7IcktzlLsUOz2fuLwSDSITQKT5HvLeubFJOoFwtQrVOIBhw2VGC5phOYE= =nBRc -----END PGP SIGNATURE----- -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs