Andres Freund <and...@2ndquadrant.com> writes: > On 2013-06-27 10:29:14 -0400, Tom Lane wrote: >> Your proposed patch will only fix the problem for dumps created after >> it ships. In the past, we've tried to deal with this type of issue by >> having pg_restore fix up the dependencies when reading a dump, so that >> it would still work on existing dumps.
> Yes :(. On the other hand, it's probably not too common to create > comments on indexes that haven't been created explicitly. Perhaps. The lack of previous complaints does suggest this situation isn't so common. >> I'm afraid there may be no way to do that in this case --- it doesn't >> look like there's enough info in the dump to tell where the dependency >> link should have led. But we should think about it a little before >> taking the easy way out. > The only thing I could think of - but which I thought to be too kludgey > - was to simply delay the creation of all comments and restore them > together with ACLs. I don't like that either, though we may be forced into it if we find more bugs in comment dependencies. Anyway, fixing pg_dump's logic is not wrong; I was just hoping we could also think of a workaround on the pg_restore side. regards, tom lane -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs