On 2013-06-30 15:11:24 +0300, Emre Hasegeli wrote: > 2013/6/30 Andres Freund <and...@2ndquadrant.com>: > > On 2013-06-30 10:43:49 +0000, e...@hasegeli.com wrote: > > Could you attach config.log? > > Attached.
This seems to be caused by be4585b1c27ac5dbdd0d61740d18f7ad9a00e268. The fault imo lies with openbsd which doesn't include the prerequisite sys/param.h header which defines NGROUPS: http://fxr.watson.org/fxr/source/sys/ucred.h?v=OPENBSD The other BSD flavors seems to get that right. Before that commit the checks for cmsgcred which includes sys/ucred.h happened to include params.h... Patch attached, missing the configure update since I don't have a compatible autoconf on my laptop, to produce a minimal diff. It's a bit sad that we didn't notice this despite having spoonbill reporting it, presumably for a good while: http://pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=spoonbill&dt=2013-06-29%2011%3A00%3A04&stg=configure The reason we presumably missed it is that getpeereid is properly present. Andrew: Could we perhaps check for the "Report this to" bit in the buildfarm? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
diff --git a/configure.in b/configure.in index 58ece5b..fa37bda 100644 --- a/configure.in +++ b/configure.in @@ -982,7 +982,7 @@ AC_SUBST(OSSP_UUID_LIBS) ## dnl sys/socket.h is required by AC_FUNC_ACCEPT_ARGTYPES -AC_CHECK_HEADERS([crypt.h dld.h fp_class.h getopt.h ieeefp.h ifaddrs.h langinfo.h poll.h pwd.h sys/ioctl.h sys/ipc.h sys/poll.h sys/pstat.h sys/resource.h sys/select.h sys/sem.h sys/shm.h sys/socket.h sys/sockio.h sys/tas.h sys/time.h sys/ucred.h sys/un.h termios.h ucred.h utime.h wchar.h wctype.h]) +AC_CHECK_HEADERS([crypt.h dld.h fp_class.h getopt.h ieeefp.h ifaddrs.h langinfo.h poll.h pwd.h sys/ioctl.h sys/ipc.h sys/param.h sys/poll.h sys/pstat.h sys/resource.h sys/select.h sys/sem.h sys/shm.h sys/socket.h sys/sockio.h sys/tas.h sys/time.h sys/un.h termios.h ucred.h utime.h wchar.h wctype.h]) # On BSD, cpp test for net/if.h will fail unless sys/socket.h # is included first. @@ -993,6 +993,14 @@ AC_CHECK_HEADERS(net/if.h, [], [], #endif ]) +# On OpenBSD including sys/ucred.h without sys/params.h will fail +AC_CHECK_HEADERS(sys/ucred.h, [], [], +[AC_INCLUDES_DEFAULT +#ifdef HAVE_SYS_PARAM_H +#include <sys/param.h> +#endif +]) + # At least on IRIX, cpp test for netinet/tcp.h will fail unless # netinet/in.h is included first. AC_CHECK_HEADERS(netinet/in.h) @@ -1133,6 +1141,9 @@ PGAC_TYPE_LOCALE_T AC_CHECK_TYPES([struct cmsgcred], [], [], [#include <sys/socket.h> +#ifdef HAVE_SYS_PARAM_H +#include <sys/param.h> +#endif #ifdef HAVE_SYS_UCRED_H #include <sys/ucred.h> #endif])
-- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
