Robert Haas <[email protected]> writes: > On Wed, Dec 6, 2017 at 5:01 AM, Amit Khandekar <[email protected]> wrote: >> In attached revised patch, just added some comments in the changes that you >> did.
> Committed, thanks. While this patch (looks like it) fixes the logic error, it does nothing for the problem that the committed test cases don't actually exercise any of this code on most machines -- certainly not whichever one is producing the code coverage report: https://coverage.postgresql.org/src/backend/executor/nodeAppend.c.gcov.html Can we do something with Andres' suggestion of running these test cases under parallel_leader_participation = off? regards, tom lane
