Re: pgsql: Move strtoint() to common

[Michael Paquier]

On Thu, Mar 15, 2018 at 06:57:27PM -0400, Tom Lane wrote:
> I think what's wrong is that src/tools/msvc/ecpg_regression.proj
> needs to be taught that tests under ecpg/test/compat-oracle need
> to be run with "-C ORACLE".  Neither that directory nor that
> switch existed before yesterday.  There's already stuff in there
> that knows about "-C INFORMIX", but beyond seeing the switch it
> looks like line noise to me, so I'm not volunteering to fix it.

I can confirm that commit 3b7ab43 is at fault, that I can see the
failure, and that the patch attached fixes the failure.
--
Michael

diff --git a/src/tools/msvc/ecpg_regression.proj b/src/tools/msvc/ecpg_regression.proj
index 745aa19e1b..9fa4a69021 100644
--- a/src/tools/msvc/ecpg_regression.proj
+++ b/src/tools/msvc/ecpg_regression.proj
@@ -33,6 +33,9 @@
   <CreateProperty Value="-C INFORMIX -r no_indicator" Condition="'%(Pgc.FileName)'=='rnull'">
    <Output TaskParameter="Value" PropertyName="ECPGPARAM" />
   </CreateProperty>
+  <CreateProperty Value="-C ORACLE" Condition="'%(Pgc.RelativeDir)'=='$(TESTDIR)\compat_oracle\'">
+   <Output TaskParameter="Value" PropertyName="ECPGPARAM" />
+  </CreateProperty>
   <CreateProperty Value="-c" Condition="'%(Pgc.FileName)'=='array_of_struct'">
    <Output TaskParameter="Value" PropertyName="ECPGPARAM" />
   </CreateProperty>

signature.asc
Description: PGP signature