On 10 November 2018 at 14:41, Andres Freund <[email protected]> wrote: > These days locking and plan invalidation ought to ensure that dropped > columns are not accessed in query plans. Therefore this commit just > drops the insufficient check in slot_getattr(). It's possible that > we'll find some holes againt use of dropped columns, but if so, those > need to be addressed independent of slot_getattr(), as most accesses > don't go through that function anyway.
Would it not be worth an Assert(!TupleDescAttr(tupleDesc, attnum - 1)->attisdropped); so that we're more likely to discover any issues where cached plans are not invalidated correctly? -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
