On 2019-Jul-10, Michael Paquier wrote: Hello
> This commit has broken the buildfarm on REL_11_STABLE for a couple of > animals: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2019-07-10%2006%3A27%3A02 Argh. You say "a couple", you mean "half the buildfarm for that branch" :-( > error: ‘for’ loop initial declarations are only allowed in C99 mode > for (int i = 0; i < trigForm->tgnargs; i++) > > This gets fixed with the attached. I would personally keep the code > consistent for v12 and HEAD for this code path, but I am fine to let > you decide the way you prefer. I kinda like block-scoped variables, braindead though they are in C, so I'll just patch pg11. It's not like this code changes too much anyway (famous last words). Thanks for pinging -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
