On Wed, Feb 19, 2020 at 04:01:54PM -0500, Tom Lane wrote:
> Surely this patch broke the error case in haveNativeWindowsIPv6routines()?
> That is, in the admittedly unlikely case that LoadLibraryA("ws2_32")
> succeeds but GetProcAddress(hLibrary, "getaddrinfo") doesn't, what you
> now have will do FreeLibrary(hLibrary) and then proceed to use the
> now-dangling hLibrary pointer anyway.You are right, thanks! This block has no meaning anymore, so removed. For the note, it looks that we could get completely rid of src/port/getaddrinfo.c once we drop support for XP as IPv6 support is enabled by default on Vista and Windows 7. For XP, one needs to install an extra module manually. Do you think that there are other platforms using our port implementation for getaddrinfo() except Windows? That's not material for today, obviously. -- Michael
signature.asc
Description: PGP signature
