On Sun, Mar 29, 2020 at 3:15 PM Andres Freund <and...@anarazel.de> wrote: > Is it perhaps possible to silence the warnign with somethign along the > lines of > Assert(nhtids + vacposting->ndeletedtids == BTreeTupleGetNPosting(origtuple)) > I don't know this code, but it looks like that'd have to be true? > Perhaps that'd be enough to silence coverity too?
It would have to be true. It's a tautology. That is, the value of nhtids comes from "vacposting->ndeletedtids" and "BTreeTupleGetNPosting(origtuple)" anyway, and we don't mutate any of that state in _bt_update_posting(). Wouldn't it at least be necessary to Assert() something about the final tuple, and/or other work state? -- Peter Geoghegan
