On 2020-Sep-07, Tom Lane wrote: > Pavel Stehule <pavel.steh...@gmail.com> writes: > > here is a patch > > What exactly is this supposed to fix? > > I didn't bother tracking down exactly where initdb.c is getting > stringinfo.h from, but it clearly does import it somewhere in > our rat's nest of headers.
You can see it here: https://doxygen.postgresql.org/initdb_8c.html It's through xlog_internal.h (not that it matters much). We do the indirect-header thing all over the place. There's no point in trying to avoid it completely. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services