Fix amcheck child check pg_upgrade bug. Commit d114cc53 overlooked the fact that pg_upgrade'd B-Tree indexes have leaf page high keys whose offset numbers do not match the one from the copy of the tuple one level up (the copy stored with a downlink for leaf page's right sibling page). This led to false positive reports of corruption from bt_index_parent_check() when it was called to verify a pg_upgrade'd index.
To fix, skip comparing the offset number on pg_upgrade'd B-Tree indexes. Author: Anastasia Lubennikova <[email protected]> Author: Peter Geoghegan <[email protected]> Reported-By: Andrew Bille <[email protected]> Diagnosed-By: Anastasia Lubennikova <[email protected]> Bug: #16619 Discussion: https://postgr.es/m/[email protected] Backpatch: 13-, where child check was enhanced. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/aac80bfcddf7df3fbd1eb73e8a386115d922c714 Modified Files -------------- contrib/amcheck/verify_nbtree.c | 34 ++++++++++++++++++++++++++++------ 1 file changed, 28 insertions(+), 6 deletions(-)
