On Wed, 7 Apr 2021 at 01:53, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > I did not intend to have the define defined at all times. Leaving it > there was an oversight. Let's just remove the #define line; users > interested in that output can turn it on when they need it. Removing it > means less clutter in the buildfarm output. Interesting conditions that > the test should check for should be tested and dealt with by using > pg_fatal, so that the test framework correctly detects a failure. The > pg_debug lines are there just to debug the test itself. > > Now about the define being called DEBUG, that was just a silly > oversight; your suggestion to change it to DEBUG_OUTPUT is good, so > let's do that. > > I +1 you pushing your patch.
Thanks for having a look at this. I've just pushed a small fix to do the rename and remove the #define. David
