On 12/14/21 00:17, Michael Paquier wrote: > On Mon, Dec 13, 2021 at 11:47:36AM -0500, Andrew Dunstan wrote: >> No. The code only sets them if they have not been previously set by >> buildenv.pl or the calling environment. That's what "||=" means. > Well, using ||= after the fact means that it is not possible to delete > any of those environment variables either in buildenv.pl, nor is it > possible to set them to empty string values, as vcregress.pl would > just reset them to the default value. And that's the case I am > arguing for here. We don't have any need to drop those default values > at all. What I am arguing for here is the possibility to have > something more flexible than what HEAD proposes. > > So, if we do something like say the attached, then it is possible to > handle environments like mine, while keeping the flexibility you are > looking for to set those defaults. So that would be the best of both > worlds, no?. I also think that we had better document all that > properly, as we do for any other TAP-related variable that can be used > in vcregress.pl. All that leads me to the attached.
Ok, if you think it's important then do it. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
