On 2/14/22 14:36, Alvaro Herrera wrote:
On 2022-Feb-13, Tomas Vondra wrote:
Fixing the tests however uncovered a bug in the code, because sequence
callbacks did not handle skip-empty-xacts properly. For trasactional
increments we need to check/update the xact_wrote_changes flag, and emit
the BEGIN if it's the first change in the transaction.
Hmm. Perhaps there should be a separate test script that runs various
things under skip-empty-xacts=0 and somehow protected against ancillary
activities (maybe a TAP test using autovacuum=0), just so that this new
code is covered ...
I'm not sure what exactly would be the benefit?
Yeah, it's pointless.
I propose the attached comment additions instead.
The comments seem fine to me (although not really related to these
commits about sequence decoding).
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
