Re: pgsql: Fix pg_basebackup with in-place tablespaces.

[David Steele]

On 3/14/22 19:31, Thomas Munro wrote:

Fix pg_basebackup with in-place tablespaces.

Previously, pg_basebackup from a cluster that contained an 'in-place'
tablespace, as introduced by commit 7170f215, would produce a harmless
warning on Unix and fail completely on Windows.

Perhaps I'm being picky, but seems like this logic should be wrapped in:

if (allow_in_place_tablespaces)
{
    <...>
}

I worry about strange effects when this GUC is not enabled.

Regards,
-David