Justin Pryzby <pry...@telsasoft.com> writes:
> On Fri, Aug 26, 2022 at 02:02:33PM +0000, Peter Eisentraut wrote:
>> Remove unnecessary casts in free() and pfree()
> This seems to be breaking cfbot's "warnings" test.
> [07:49:48.983] label.c:665:10: error: passing argument 1 of ‘pfree’ discards
> ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
> [07:49:48.983] 665 | pfree(temp);
Hmm, well, casting away const is certainly not within pfree's remit,
so I'm glad we changed this.
A quick-n-dirty fix is to cast away const at this call site, but
I wonder whether this isn't a symptom of poor const choices.
I'll take a look later today if no one beats me to it.
regards, tom lane
