Rename force_parallel_mode to debug_parallel_query force_parallel_mode is meant to be used to allow us to exercise the parallel query infrastructure to ensure that it's working as we expect. It seems some users think this GUC is for forcing the query planner into picking a parallel plan regardless of the costs. A quick look at the documentation would have made them realize that they were wrong, but the GUC is likely too conveniently named which, evidently, seems to often result in users expecting that it forces the planner into usefully parallelizing queries.
Here we rename the GUC to something which casual users are less likely to mistakenly think is what they need to make their query run more quickly. For now, the old name can still be used. We'll revisit if the old name mapping can be removed once the buildfarm configs are all updated. Reviewed-by: John Naylor Discussion: https://postgr.es/m/caaphdvrsoi92_ua7peahzmh-s4xv+mghqwa+grp8b1kjps1...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5352ca22e0012d48055453ca9992a9515d811291 Modified Files -------------- doc/src/sgml/config.sgml | 8 +++--- doc/src/sgml/regress.sgml | 2 +- src/backend/access/transam/parallel.c | 4 +-- src/backend/commands/explain.c | 4 +-- src/backend/optimizer/plan/planmain.c | 4 +-- src/backend/optimizer/plan/planner.c | 20 +++++++------- src/backend/utils/misc/guc.c | 1 + src/backend/utils/misc/guc_tables.c | 32 ++++++++++++---------- src/include/optimizer/optimizer.h | 12 ++++---- src/pl/plpgsql/src/pl_exec.c | 2 +- src/test/isolation/expected/deadlock-parallel.out | 6 ++-- src/test/isolation/specs/deadlock-parallel.spec | 16 +++++------ .../isolation/specs/serializable-parallel.spec | 2 +- src/test/modules/libpq_pipeline/libpq_pipeline.c | 4 +-- src/test/modules/test_oat_hooks/test_oat_hooks.c | 2 +- src/test/regress/expected/multirangetypes.out | 2 +- src/test/regress/expected/rangetypes.out | 2 +- src/test/regress/expected/select_parallel.out | 12 ++++---- src/test/regress/expected/with.out | 2 +- src/test/regress/sql/multirangetypes.sql | 2 +- src/test/regress/sql/rangetypes.sql | 2 +- src/test/regress/sql/select_parallel.sql | 12 ++++---- src/test/regress/sql/with.sql | 2 +- 23 files changed, 79 insertions(+), 76 deletions(-)
