On 22.08.23 22:08, Jeff Davis wrote:
Fix pg_dump assertion failure when dumping pg_catalog.
Commit 396d348b04 did not account for the default collation.
Also, use pg_log_warning() instead of Assert().
Looking at this:
pg_log_warning("invalid collation \"%s\"", qcollname);
qcollname is already a quoted identifier, so this message would be
doubly quoted. Maybe you should use collinfo->dobj.name in the messages.
Also, for
pg_fatal("unrecognized collation provider '%c'", collprovider[0]);
use double quotes.
