On Thu, Sep 28, 2023 at 10:08 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > Amit Langote <amit...@postgresql.org> writes: > > After these modifications, the ExecEnd*() routines for ValuesScan, > > NamedTuplestoreScan, and WorkTableScan became redundant. So, this > > commit removes them. > > This seems like quite a bad idea. From a documentation standpoint > alone, it would be far better for these functions to exist but be > empty.
Actually, the documentation aspect of this change does bother me a bit, but I also agree with Robert's preference to remove such empty functions altogether to shave some albeit few CPU cycles off [1]. I am fine with reverting this part if you insist though. -- Thanks, Amit Langote EDB: http://www.enterprisedb.com
