Allow subquery pullup to wrap a PlaceHolderVar in another one. The code for wrapping subquery output expressions in PlaceHolderVars believed that if the expression already was a PlaceHolderVar, it was never necessary to wrap that in another one. That's wrong if the expression is underneath an outer join and involves a lateral reference to outside that scope: failing to add an additional PHV risks evaluating the expression at the wrong place and hence not forcing it to null when the outer join should do so. This is an oversight in commit 9e7e29c75, which added logic to forcibly wrap lateral-reference Vars in PlaceHolderVars, but didn't see that the adjacent case for PlaceHolderVars needed the same treatment.
The test case we have for this doesn't fail before 4be058fe9, but now that I see the problem I wonder if it is possible to demonstrate related errors before that. That's moot though, since all such branches are out of support. Per bug #18284 from Holger Reise. Back-patch to all supported branches. Discussion: https://postgr.es/m/18284-47505a20c2364...@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/29f114b6ff0c4ccad29b3a3707ab2c299647d450 Modified Files -------------- src/backend/optimizer/prep/prepjointree.c | 9 +++++++-- src/test/regress/expected/join.out | 27 +++++++++++++++++++++++++++ src/test/regress/sql/join.sql | 12 ++++++++++++ 3 files changed, 46 insertions(+), 2 deletions(-)