Fix plpgsql to allow new-style SQL CREATE FUNCTION as a SQL command. plpgsql fails on new-style CREATE FUNCTION/PROCEDURE commands within a routine or DO block, because make_execsql_stmt believes that a semicolon token always terminates a SQL command. Now, that's actually been wrong since the day it was written, because CREATE RULE has long allowed multiple rule actions separated by semicolons. But there are few enough people using multi-action rules that there was never an attempt to fix it. New-style SQL functions, though, are popular.
psql has this same problem of "does this semicolon really terminate the command?". It deals with CREATE RULE by counting parenthesis nesting depth: a semicolon within parens doesn't end a command. Commits e717a9a18 and 029c5ac03 created a similar heuristic to count matching BEGIN/END pairs (but only within CREATEs, so as not to be fooled by plain BEGIN). That's survived several releases now without trouble reports, so let's just absorb those heuristics into plpgsql. Per report from Samuel Dussault. Back-patch to v14 where new-style SQL function syntax came in. Discussion: https://postgr.es/m/yt2pr01mb88552c3e9ad40a6c038774a781...@yt2pr01mb8855.canprd01.prod.outlook.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/00f941356e56bd80427765a6a8261eb71e4eb3cc Modified Files -------------- src/pl/plpgsql/src/Makefile | 5 +- src/pl/plpgsql/src/expected/plpgsql_misc.out | 31 ++++++++++++ src/pl/plpgsql/src/meson.build | 3 +- src/pl/plpgsql/src/pl_gram.y | 72 ++++++++++++++++++++++++---- src/pl/plpgsql/src/sql/plpgsql_misc.sql | 22 +++++++++ 5 files changed, 122 insertions(+), 11 deletions(-)