Adjust reltarget assignment for UPPERREL_PARTIAL_DISTINCT rel A comment in grouping_planner() claimed that the PlannerInfo upper_targets array was not used in core code. However, the code that generated the paths for the UPPERREL_PARTIAL_DISTINCT rel made that comment untrue.
Here we adjust the create_distinct_paths() function signature to pass down the PathTarget the same as is done for create_grouping_paths(), thus making the aforementioned comment true again. In passing adjust the order of the upper_targets[] assignments. These seem to be following the reverse enum order apart from UPPERREL_PARTIAL_DISTINCT. Also, update the header comment for generate_gather_paths() to mention the function is also used to create gather paths for partial distinct paths. Author: Richard Guo, David Rowley Discussion: https://postgr.es/m/cambws48u9vovooujsys1qoac9wvgvmba+wt1dx8kvxf5gpz...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/902900b308fb38543b95526b1f384bf3cce2f514 Modified Files -------------- src/backend/optimizer/path/allpaths.c | 8 ++++---- src/backend/optimizer/plan/planner.c | 22 ++++++++++++++-------- 2 files changed, 18 insertions(+), 12 deletions(-)