Fix mis-rounding and overflow hazards in date_bin(). In the case where the target timestamp is before the origin timestamp and their difference is already an exact multiple of the stride, the code incorrectly subtracted the stride anyway.
Also detect several integer-overflow cases that previously produced bogus results. (The submitted patch tried to avoid overflow, but I'm not convinced it's right, and problematic cases are so far out of the plausibly-useful range that they don't seem worth sweating over. Let's just use overflow-detecting arithmetic and throw errors.) timestamp_bin() and timestamptz_bin() are basically identical and so had identical bugs. Fix both. Report and patch by Moaaz Assali, adjusted some by me. Back-patch to v14 where date_bin() was introduced. Discussion: https://postgr.es/m/CALkF+nvtuas-2kydG-WfofbRSJpyODAJWun==w-yo5j2r4m...@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fe3b1b575e24748ddb9b3b67394fa10c279090ac Modified Files -------------- src/backend/utils/adt/timestamp.c | 72 +++++++++++++++++++++++-------- src/test/regress/expected/timestamp.out | 14 ++++++ src/test/regress/expected/timestamptz.out | 14 ++++++ src/test/regress/sql/timestamp.sql | 8 ++++ src/test/regress/sql/timestamptz.sql | 8 ++++ 5 files changed, 97 insertions(+), 19 deletions(-)