Hello. At Thu, 14 Mar 2024 11:25:42 +0000, Alexander Korotkov <akorot...@postgresql.org> wrote in > Add TAP tests for timeouts > > This commit adds new tests to verify that transaction_timeout, > idle_session_timeout, and idle_in_transaction_session_timeout work as > expected. > We introduce new injection points in before throwing a timeout FATAL error > and check these injection points are reached. > > Discussion: > https://postgr.es/m/CAAhFRxiQsRs2Eq5kCo9nXE3HTugsAAJdSQSmxncivebAxdmBjQ%40mail.gmail.com > Author: Andrey Borodin > Reviewed-by: Alexander Korotkov
In 005_timeouts.pl, I found the following comment. > # If we send \q with $psql_session->quit it can get to pump already closed. > # So \q is in initial script, here we only finish IPC::Run. > $psql_session->{run}->finish; I'm not sure if "it can get to pump already closed." makes sense. I guess that it means "the command can get to be pumped (or "can be sent") to the session already closed" or something similar? > # 2. Test of the sidle in transaction timeout s/sidle/idle/ ? > # Wait until the backend is in the timeout injection point. I'm not sure, but it seems that "is in" meant "passes" or something like? regards. -- Kyotaro Horiguchi NTT Open Source Software Center