At Sun, 07 Apr 2024 22:28:06 +0000, Alexander Korotkov <akorot...@postgresql.org> wrote in > Transform OR clauses to ANY expression
This commit introduces a message like this: > gettext_noop("Set the minimum length of the list of OR clauses to attempt the > OR-to-ANY transformation."), Unlike the usual phrasing of similar messages in this context, which use the form "Sets the minimum length of...", this message uses an imperative form ("Set"). I believe it would be better to align the tone of this message with the others by changing "Set" to "Sets". regards. diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c index 83e3a59d7e..a527ffe0b0 100644 --- a/src/backend/utils/misc/guc_tables.c +++ b/src/backend/utils/misc/guc_tables.c @@ -3670,7 +3670,7 @@ struct config_int ConfigureNamesInt[] = { {"or_to_any_transform_limit", PGC_USERSET, QUERY_TUNING_OTHER, - gettext_noop("Set the minimum length of the list of OR clauses to attempt the OR-to-ANY transformation."), + gettext_noop("Sets the minimum length of the list of OR clauses to attempt the OR-to-ANY transformation."), gettext_noop("Once the limit is reached, the planner will try to replace expression like " "'x=c1 OR x=c2 ..' to the expression 'x = ANY(ARRAY[c1,c2,..])'"), GUC_EXPLAIN -- Kyotaro Horiguchi NTT Open Source Software Center