Push dedicated BumpBlocks to the tail of the blocks list BumpContext relies on using the head block from its 'blocks' field to use as the current block to allocate new chunks to. When we receive an allocation request larger than allocChunkLimit, we place these chunks on a new dedicated block and, until now, we pushed the block onto the *head* of the 'blocks' list.
This behavior caused the previous bump block to no longer be available for new normal-sized (non-large) allocations and would result in blocks only being partially filled if a large allocation request arrived before the block became full. Here adjust the code to push these dedicated blocks onto the *tail* of the blocks list so that the head block remains intact and available to be used by normal allocation request sizes until it becomes full. In passing, make the elog(ERROR) calls for the unsupported callbacks consistent. Likewise for the header comments for those functions. Discussion: https://postgr.es/m/caaphdvp9___r-ayjj0nz6gd3mecgwgz0_6zptwpwj+zqhtm...@mail.gmail.com Discussion: https://postgr.es/m/CAApHDvqerXpzUnuDQfUEi3DZA+9=ud9wst3ruxn5b6pcoos...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6d2fd66b9908d1557d7e49b1bdb4c597192f3729 Modified Files -------------- src/backend/utils/mmgr/bump.c | 17 ++++++++++------- src/test/regress/expected/sysviews.out | 2 +- 2 files changed, 11 insertions(+), 8 deletions(-)