Explain dropdb can't use syscache because of TOAST Add a comment explaining dropdb() can't rely on syscache. The issue with flattened rows was fixed by commit 0f92b230f88b, but better to have a clear explanation why the systable scan is necessary. The other places doing in-place updates on pg_database have the same comment.
Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix. Author: Yugo Nagata Backpatch-through: 12 Discussion: https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=bicd3mh8c2jdhlofpxsw3m2dkdfw...@mail.gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/de8770b47f1f763378d9d130d69e3a7b8a54684a Modified Files -------------- src/backend/commands/dbcommands.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)