On Wed, Oct 16, 2024 at 10:35 PM Peter Eisentraut <pe...@eisentraut.org> wrote: > On 02.09.24 01:55, Alexander Korotkov wrote: > > On Mon, Sep 2, 2024 at 2:28 AM Michael Paquier <mich...@paquier.xyz> wrote: > >> On Sun, Sep 01, 2024 at 10:35:27PM +0300, Alexander Korotkov wrote: > >>> This path hasn't changes since the patch revision when it was a > >>> utility command. I agree that this doesn't look like proper path for > >>> stored procedure. But I don't think src/backend/utils/adt is > >>> appropriate path either, because it's not really about data type. > >>> pg_wal_replay_wait() looks a good neighbor for > >>> pg_wal_replay_pause()/pg_wal_replay_resume() and other WAL-related > >>> functions. So, what about moving it to src/backend/access/transam? > >> > >> Moving the new function to xlogfuncs.c while publishing > >> WaitForLSNReplay() makes sense to me. > > > > Thank you for proposal. I like this. > > > > Could you, please, check the attached patch? > > We still have stuff in src/backend/commands/waitlsn.c that is nothing > like a "command". You have moved some stuff elsewhere, but what are you > planning to do with the rest?
Thank you for spotting this another time. What about moving that somewhere like src/backend/access/transam/xlogwait.c ? ------ Regards, Alexander Korotkov Supabase
