pg_combinebackup: When reconstructing, avoid double slash in filename. This function is always called with a relative_path that ends in a slash, so there's no need to insert a second one. So, don't. Instead, add an assertion to verify that nothing gets broken in the future, and adjust the comments.
While this is not a critical bug, the duplicate slash is visible in error messages, which could create confusion, so back-patch to v17. This is also better in that it keeps the code consistent across branches. Patch by me, reviewed by Bertrand Drouvot and Amul Sul. Discussion: http://postgr.es/m/CA+TgmoaD7dBYPqe7kMtO0dyto7rd0rUh7joh=jpusafszky...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6c24801b1717ff68695647068a5ad8ff88f7639d Modified Files -------------- src/bin/pg_combinebackup/reconstruct.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
