Improve accounting for PredXactList, RWConflictPool and PGPROC Various places allocated shared memory by first allocating a small chunk using ShmemInitStruct(), followed by ShmemAlloc() calls to allocate more memory. Unfortunately, ShmemAlloc() does not update ShmemIndex, so this affected pg_shmem_allocations - it only shown the initial chunk.
This commit modifies the following allocations, to allocate everything as a single chunk, and then split it internally. - PredXactList - RWConflictPool - PGPROC structures - Fast-Path Lock Array The fast-path lock array is allocated separately, not as a part of the PGPROC structures allocation. Author: Rahila Syed <rahilasye...@gmail.com> Reviewed-by: Andres Freund <and...@anarazel.de> Reviewed-by: Nazir Bilal Yavuz <byavu...@gmail.com> Reviewed-by: Tomas Vondra <to...@vondra.me> Discussion: https://postgr.es/m/cah2l28vhzrankszhqz7dexurxkncxfirnuw68zd7+hvaqas...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/46df9487d973d00c83a7962935063f3a6518939c Modified Files -------------- src/backend/storage/lmgr/predicate.c | 30 ++++++++---- src/backend/storage/lmgr/proc.c | 93 +++++++++++++++++++++++++++--------- 2 files changed, 91 insertions(+), 32 deletions(-)
