pg_dump: include comments on valid not-null constraints, too We were missing collecting comments for not-null constraints that are dumped inline with the table definition (i.e., valid ones), because they aren't represented by a separately dumpable object. Fix by creating separate TocEntries for the comments.
Co-Authored-By: Jian He <jian.universal...@gmail.com> Co-Authored-By: Álvaro Herrera <alvhe...@kurilemu.de> Reported-By: Fujii Masao <masao.fu...@oss.nttdata.com> Reviewed-By: Fujii Masao <masao.fu...@oss.nttdata.com> Discussion: https://postgr.es/m/d50ff977-c728-4e9e-8488-fc2688e08...@oss.nttdata.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/47fb87563bf3cca2244840241dde2eb93830559b Modified Files -------------- doc/src/sgml/ref/pg_dump.sgml | 2 +- src/bin/pg_dump/pg_dump.c | 92 +++++++++++++++++++++++++++---- src/bin/pg_dump/pg_dump.h | 1 + src/bin/pg_dump/t/002_pg_dump.pl | 32 ++++++++++- src/test/regress/expected/constraints.out | 2 + src/test/regress/sql/constraints.sql | 3 + 6 files changed, 118 insertions(+), 14 deletions(-)