Fix sslkeylogfile error handling logging When sslkeylogfile has been set but the file fails to open in an otherwise successful connection, the log entry added to the conn object is never printed. Instead print the error on stderr for increased visibility. This is a debugging tool so using stderr for logging is appropriate. Also while there, remove the umask call in the callback as it's not useful.
Issues noted by Peter Eisentraut in post-commit review, backpatch down to 18 when support for sslkeylogfile was added Author: Daniel Gustafsson <dan...@yesql.se> Reported-by: Peter Eisentraut <pe...@eisentraut.org> Reviewed-by: Peter Eisentraut <pe...@eisentraut.org> Discussion: https://postgr.es/m/70450bee-cfaa-48ce-8980-fc7efcfeb...@eisentraut.org Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/39f01083facd0ddc0040662a71159e9987813c2c Modified Files -------------- src/interfaces/libpq/fe-secure-openssl.c | 20 ++++++++++++-------- src/test/ssl/t/001_ssltests.pl | 7 +++++++ 2 files changed, 19 insertions(+), 8 deletions(-)
