Centralize collection of catalog info needed early in the planner There are several pieces of catalog information that need to be retrieved for a relation during the early stage of planning. These include relhassubclass, which is used to clear the inh flag if the relation has no children, as well as a column's attgenerated and default value, which are needed to expand virtual generated columns. More such information may be required in the future.
Currently, these pieces of catalog data are collected in multiple places, resulting in repeated table_open/table_close calls for each relation in the rangetable. This patch centralizes the collection of all required early-stage catalog information into a single loop over the rangetable, allowing each relation to be opened and closed only once. Author: Richard Guo <guofengli...@gmail.com> Reviewed-by: Robert Haas <robertmh...@gmail.com> Reviewed-by: Tom Lane <t...@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAMbWs4-bFJ1At4btk5wqbezdu8PLtQ3zv-aiaY3ry9Ymm=j...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/904f6a593a06649f77597ab9a72ef97c21e39a93 Modified Files -------------- src/backend/optimizer/plan/planner.c | 31 +--- src/backend/optimizer/plan/subselect.c | 9 +- src/backend/optimizer/prep/prepjointree.c | 299 ++++++++++++++++++------------ src/include/optimizer/prep.h | 2 +- 4 files changed, 190 insertions(+), 151 deletions(-)
