Expand virtual generated columns before sublink pull-up Currently, we expand virtual generated columns after we have pulled up any SubLinks within the query's quals. This ensures that the virtual generated column references within SubLinks that should be transformed into joins are correctly expanded. This approach works well and has posed no issues.
In an upcoming patch, we plan to centralize the collection of catalog information needed early in the planner. This will help avoid repeated table_open/table_close calls for relations in the rangetable. Since this information is required during sublink pull-up, we are moving the expansion of virtual generated columns to occur beforehand. To achieve this, if any EXISTS SubLinks can be pulled up, their rangetables are processed just before pulling them up. Author: Richard Guo <guofengli...@gmail.com> Reviewed-by: Robert Haas <robertmh...@gmail.com> Reviewed-by: Tom Lane <t...@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAMbWs4-bFJ1At4btk5wqbezdu8PLtQ3zv-aiaY3ry9Ymm=j...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e0d05295268e3811e6743403cb779f21d1662426 Modified Files -------------- src/backend/optimizer/plan/planner.c | 17 ++++++++-------- src/backend/optimizer/plan/subselect.c | 27 +++++++++++++++++++++++++ src/backend/optimizer/prep/prepjointree.c | 20 ++++++++---------- src/include/optimizer/prep.h | 2 +- src/test/regress/expected/generated_virtual.out | 22 ++++++++++++++++++++ src/test/regress/sql/generated_virtual.sql | 9 +++++++++ 6 files changed, 76 insertions(+), 21 deletions(-)
