Fix replica identity check for INSERT ON CONFLICT DO UPDATE. If an INSERT has an ON CONFLICT DO UPDATE clause, the executor must check that the target relation supports UPDATE as well as INSERT. In particular, it must check that the target relation has a REPLICA IDENTITY if it publishes updates. Formerly, it was not doing this check, which could lead to silently breaking replication.
Fix by adding such a check to CheckValidResultRel(), which requires adding a new onConflictAction argument. In back-branches, preserve ABI compatibility by introducing a wrapper function with the original signature. Author: Zhijie Hou <[email protected]> Reviewed-by: Ashutosh Bapat <[email protected]> Reviewed-by: Dean Rasheed <[email protected]> Tested-by: Chao Li <[email protected]> Discussion: https://postgr.es/m/os3pr01mb57180c87e43a679a730482df94...@os3pr01mb5718.jpnprd01.prod.outlook.com Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5386bfb9c1f566887d084e4ea2e350e7efd188c1 Modified Files -------------- src/backend/commands/copyfrom.c | 2 +- src/backend/executor/execMain.c | 12 +++++++++++- src/backend/executor/execPartition.c | 9 +++++++-- src/backend/executor/nodeModifyTable.c | 3 ++- src/include/executor/executor.h | 1 + src/test/regress/expected/publication.out | 23 +++++++++++++++++++++++ src/test/regress/sql/publication.sql | 27 +++++++++++++++++++++++++++ 7 files changed, 72 insertions(+), 5 deletions(-)
