amcheck: Fix snapshot usage in bt_index_parent_check We were using SnapshotAny to do some index checks, but that's wrong and causes spurious errors when used on indexes created by CREATE INDEX CONCURRENTLY. Fix it to use an MVCC snapshot, and add a test for it.
Backpatch of 6bd469d26aca to branches 14-16. I previously misidentified the bug's origin: it came in with commit 7f563c09f890 (pg11-era, not 5ae2087202af as claimed previously), so all live branches are affected. Also take the opportunity to fix some comments that we failed to update in the original commits and apply pgperltidy. In branch 14, remove the unnecessary test plan specification (which would have need to have been changed anyway; c.f. commit 549ec201d613.) Diagnosed-by: Donghang Lin <[email protected]> Author: Mihail Nikalayeu <[email protected]> Reviewed-by: Andrey Borodin <[email protected]> Backpatch-through: 17 Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dmykuqg0km87fkosd...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1f28982e409451249646910e585469076c43ba8f Modified Files -------------- contrib/amcheck/t/002_cic.pl | 3 ++- contrib/amcheck/verify_nbtree.c | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-)
