Fix COPY FROM ON_ERROR SET_NULL with selective column list When using COPY FROM ... ON_ERROR SET_NULL with a selective column list, the domain_with_constraint array was incorrectly allocated based on the length of the target column list. While the array was populated sequentially, CopyFromTextLikeOneRow attempted to access it using the physical attribute index (attnum - 1). This mismatch caused out-of-bounds reads when targeting high-numbered columns, allowing NULL values to bypass NOT NULL domain checks and be silently inserted.
Fix by allocating the array to match the total number of physical attributes (num_phys_attrs) and indexing via attnum - 1, bringing it into alignment with other per-column arrays in BeginCopyFrom. Author: SATYANARAYANA NARLAPURAM <[email protected]> Reviewed-by: Jian He <[email protected]> Reviewed-by: Chao Li <[email protected]> Reviewed-by: Fujii Masao <[email protected]> Discussion: https://postgr.es/m/cahg+qddej0c0gwji2fnbirzhgzyznpitwc1p5b_-dsnczq-...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1164a822729a496baedfc4068a6c86e247d5934e Modified Files -------------- src/backend/commands/copyfrom.c | 8 ++------ src/test/regress/expected/copy2.out | 4 ++++ src/test/regress/sql/copy2.sql | 4 ++++ 3 files changed, 10 insertions(+), 6 deletions(-)
