xml2: Fix crash with namespace nodes in xpath_nodeset()

pgxmlNodeSetToText() passed nodeTab[i]->doc to xmlNodeDump() without
checking the node type, which could cause a crash as a
XML_NAMESPACE_DECL maps to a xmlNs struct.  The passed-in code would
then be dereferenced in xmlNodeDump().

This commit switches the code to render XML_NAMESPACE_DECL nodes with
xmlXPathCastNodeToString(), like xpath_table().  Some tests are added,
written by me.

Author: Andrey Chernyy <[email protected]>
Co-authored-by: Michael Paquier <[email protected]>
Discussion: https://postgr.es/m/20260611031436.5afde3cb@andrnote
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/91b57eadeb0f1f971aebfc3f9c9045477b0e0438

Modified Files
--------------
contrib/xml2/expected/xml2.out   |  8 ++++++++
contrib/xml2/expected/xml2_1.out |  8 ++++++++
contrib/xml2/sql/xml2.sql        |  3 +++
contrib/xml2/xpath.c             | 15 +++++++++++----
4 files changed, 30 insertions(+), 4 deletions(-)

Reply via email to