IS JSON/JSON(): Protect against expressions uncoercible to text transformJsonParseArg() was not careful enough on generation of transformed expressions when starting from expressions that are not coercible to text but are in the string type category: it failed to verify that coerce_to_target_type() succeeds, and returned a NULL pointer. This leads to a later NULL dereference and crash at executor time.
This escaped noticed because it cannot happen for built-in types, all of which have casts to text. Only user-created types are potentially problematic. Fix by raising an error when a cast to text doesn't exist. This mistake came in with commit 6ee30209a6f1. Author: Ayush Tiwari <[email protected]> Reported-by: Chi Zhang <[email protected]> Reviewed-by: Srinath Reddy Sadipiralla <[email protected]> Backpatch-through: 16 Discussion: https://postgr.es/m/[email protected] Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d0acd2535b4adb21ad952d12e0f8c3fb25999d28 Modified Files -------------- src/backend/nodes/makefuncs.c | 2 ++ src/backend/parser/parse_expr.c | 10 ++++++++++ src/test/regress/expected/sqljson.out | 36 +++++++++++++++++++++++++++++++++++ src/test/regress/sql/sqljson.sql | 22 +++++++++++++++++++++ 4 files changed, 70 insertions(+)
