Misc cleanup in datachecksums_state.[ch] Move DataChecksumsWorkerResult struct to the .c file. It's not used anywhere else since commit 07009121c2 removed the injection point test code that the comment referred to.
Mark StartDataChecksumsWorkerLauncher() as static, since it's not called from outside the .c file. The DataChecksumsWorkerOperation struct can then be moved into the .c file too. Clarify the comment on StartDataChecksumsWorkerLauncher(). It said "Main entry point for datachecksumsworker launcher process", but I found that misleading. That description would be a better fit for DataChecksumsWorkerLauncherMain(), which is the process's "main" function, rather than StartDataChecksumsWorkerLauncher(). Fix comment on WaitForAllTransactionsToFinish() on postmaster death. The comment claimed that it sets "the abort flag" on postmaster death, but it actually just errors outs. Improve the comment to explain why it doesn't just use WL_EXIT_ON_PM_DEATH. Reviewed-by: Daniel Gustafsson <[email protected]> Discussion: https://www.postgresql.org/message-id/[email protected] Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0edbf72f76833a145cb8eca128b775a8f0090d15 Modified Files -------------- src/backend/postmaster/datachecksum_state.c | 35 +++++++++++++++++++++-------- src/include/postmaster/datachecksum_state.h | 26 --------------------- 2 files changed, 26 insertions(+), 35 deletions(-)
