pg_stat_io: Don't flag extends by autovacuum launcher pg_stat_io asserts on unexpected combinations of backend type and IOOp. These combinations were meant to help detect bugs given our current understanding of the system -- not serve as a set of rules for what is allowed. The autovacuum launcher scans catalog tables and may on-access prune them. This previously wouldn't have led to any extends of the relation, but now that on-access pruning may pin a page of the visibility map (4f7ecca84ddacbce27), scanning tables may lead to extending the visibility map. This would cause the launcher to trip an assert. Since there is no reason to forbid the launcher from doing extends, remove it from the list of backend type pgstat_tracks_io_op flags for doing IOOP_EXTEND.
Read-only catalog scans still don't let pruning set the VM; doing so needs table AM API changes and is left for the future. Reported-by: Ewan Young <[email protected]> Discussion: https://postgr.es/m/caon2xhnoyan9mczohhd_nl6as3qvhga0son2hyi9w6+y-_1...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4abf411e2328f57fd2547b5c2187a2159e97a606 Modified Files -------------- src/backend/utils/activity/pgstat_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
