Fix psql's pager selection for wrapped expanded output. psql decided whether to use the pager in expanded output without accounting for possible wrapping of column values. This could allow it to not use the pager in cases where it should do so.
To fix, move the IsPagerNeeded decision in print_aligned_vertical() down until after the wrapped data width is known. Then, if we're in wrapped mode, prepare a width_wrap array specifying that width (which, in vertical mode, is the same for all columns). This is fixing an omission in 27da1a796, so back-patch to v19 where that came in. Author: Chao Li <[email protected]> Reviewed-by: Erik Wienhold <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/07abbc93ba5ba41b60927221db92bc73f75fd1ba Modified Files -------------- src/bin/psql/t/030_pager.pl | 5 +++++ src/fe_utils/print.c | 53 ++++++++++++++++++++++++++++++--------------- 2 files changed, 40 insertions(+), 18 deletions(-)
