Fix socket_putmessage_noblock() to call socket_putmessage() socket_putmessage_noblock() used pq_putmessage(), which redirects to PqCommMethods->putmessage. In the common cases, this points to socket_putmessage(), but it would become incorrect if PqCommMethods points to a different implementation.
This change may look like a bug, but as far as I can see this is mostly cosmetic. The code is able to work currently, as the repalloc() done in the noblock() call ensures that the blocking path of internal_putbytes() is never reached. The issue has gone unnoticed since 2bd9e412f92b. Author: Anthonin Bonnefoy <[email protected]> Reviewed-by: Fujii Masao <[email protected]> Discussion: https://postgr.es/m/cao6_xqpf5+rzw_-xooz-d-r5x6_2jhtpnzxp0nrywihyzok...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/544d25b7af958ca6c03e98bfbc1538c295b30601 Modified Files -------------- src/backend/libpq/pqcomm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
