Initialize read stream before fetching metapage in hash bulk-deletion hashbulkdelete() fetched the relcache's cached hash metapage before calling read_stream_begin_relation(). During the read stream initialization, relation lookups may process pending relcache invalidation messages, which could cause the cached metapage to be invalidated before the read stream uses it, leading to the failure of a VACUUM bulk-deletion for a hash index.
This commit reworks the order of hashbulkdelete() so as its read stream is initialized before fetching the cached metapage, so as pending invalidation messages do not interfere with the relation scan. Issue introduced by bfa3c4f106b1. Author: Mikhail Nikalayeu <[email protected]> Reviewed-by: Bertrand Drouvot <[email protected]> Reviewed-by: Nazir Bilal Yavuz <[email protected]> Reviewed-by: Xuneng Zhou <[email protected]> Discussion: https://postgr.es/m/cadzflwvej2_7iox3zsb1p7qxw40ghuy_zczefvhdloa_3mu...@mail.gmail.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ca86d7439b1947e97d0d86036f29ebc5cb0397aa Modified Files -------------- src/backend/access/hash/hash.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-)
