Check EXECUTE privilege on functions invoked by the RI fast path ri_FastPathCheck() invokes two functions on the FK values: the equality operator's function, via the ScanKey the index AM evaluates, and, when the FK column's type differs from the PK column's, the implicit cast function. The SPI path gets EXECUTE on both checked by ExecInitFunc() when it initializes the generated query, as the referenced table's owner, but the fast path performed neither check.
Add ri_CheckFunctionPermissions() and call it once the fast-path metadata is populated, under the switch to the referenced table's owner, so the checks happen at the same point as the existing relation permission check. Add a regression test for each function, reaching the fast path through per-row validation of a new constraint, and repeat each against a partitioned referenced table, which takes the SPI path, to show that the two behave identically. Reported-by: Nikolay Samokhvalov <[email protected]> (offlist) Reviewed-by: Matheus Alcantara <[email protected]> Discussion: https://postgr.es/m/ca+hiwqgh+b7sxmsh8st18diujbhesobws0gwxqlzqrccmkv...@mail.gmail.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1a846a555afb0e5f2008f3aefe8f77acbe6ffba6 Modified Files -------------- src/backend/utils/adt/ri_triggers.c | 40 +++++++++++++++ src/test/regress/expected/foreign_key.out | 81 +++++++++++++++++++++++++++++++ src/test/regress/sql/foreign_key.sql | 81 +++++++++++++++++++++++++++++++ 3 files changed, 202 insertions(+)
