SQL/JSON: Fix PASSING of string types other than text and varchar For PASSING arguments, transformJsonValueExpr() passes values of any type of the string category to the jsonpath executor as they are, without converting them to jsonb. However, JsonItemFromDatum() only handled text and varchar among those, so passing a char(n) or name value (such as current_user), or a value of a domain over text, failed at run time:
ERROR: could not convert value of type character to jsonpath Fix by making JsonItemFromDatum() handle those types too. bpchar is handled like text, keeping its padding as to_jsonb() does, and name directly. Any other type of the string category, including domains over string types and types provided by extensions, is converted through its output function, again as to_jsonb() does. Doing this in the executor rather than coercing the argument in the parser leaves parse trees unchanged, so that existing views and rules using such PASSING arguments start working too. Oversight in commit 6185c9737cf, so back-patch to 17. Reported-by: Ilya Staroverov <[email protected]> Reported-by: chunling qin <[email protected]> Author: Ilya Staroverov <[email protected]> Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5b0e267f3528b16ecee0a3b4e4e2c34f8343290e Modified Files -------------- src/backend/utils/adt/jsonpath_exec.c | 50 ++++++++++++++++-- src/test/regress/expected/sqljson_queryfuncs.out | 64 ++++++++++++++++++++++++ src/test/regress/sql/sqljson_queryfuncs.sql | 25 +++++++++ 3 files changed, 135 insertions(+), 4 deletions(-)
